Shubham comments

Results 38 comments of


                                            Shubham

make parameter `-m` optional in `vault commit`

Solved by giving Default Vaule to - m and level in `vault revert`. TODO - Add a default vaule to path as "./" after that functionality is added

Replace `.to_string` with references wherever possible to boost performance

Also reduce the number of variables.. There are quite a lot of lets in there : )

To Figure: How to reduce the number of `match` statements without making the code error prone

Also, To find the alternative of `panic!()` macro... It isn't the best way to give errors....

To Figure: How to reduce the number of `match` statements without making the code error prone

Hi @Levi0804 , go ahead! You could add `thiserror` or even `anyhow` to make stuff easy..

Many of the functions have not been error handled : /

Hi thanks, I am aware much of the code here is not up to the mark ( or is not error handled ). A bit of back-story here - Though...

Directory recursion in `vault commit` is also considering `.vault` folder also..

`.vault` folder is ignored. Only `.vaultignore` is left.

Directory recursion in `vault commit` is also considering `.vault` folder also..

To Think: Should we ignore `.vaultignore` as a file too? Git doesn't do it...

Improve error messaging when data is undefined

Hi @evargast , I would like to give it a try. I might need help though. Can you guide me on how to approach the issue?

waydroid_magisk setup seems to failed with lxc-attach error as below

still same

Fix placement of hint parent element

Hi, Thanks for the PR. Sorry, can you provide a recording or something which explains your issue. Because, I haven't faced any issue with the hints. Probably to center the...