Josh Holmer

Results 170 comments of Josh Holmer

Sorry, I missed this MR before. It looks like there's still some issues with the build though. Would you mind taking a look? Wasm isn't my specialty.

Looks like a missing use statement this time

Just returned from vacation, so I'm looking at this again now.

Seems to still be having some issues, unfortunately.

We do have CI jobs for validating minimum rust version. Just not one for wasm currently. hack might be useful for local testing before pushing up to CI.

It looks like adding wasm tests in CI here may be a bit more complicated than in v_frame. But I'm also not an expert at Github actions. Anyway, for now...

I'm pondering whether the decrease in accuracy is worth the speed difference. I'll ask some users to see what the general vibe is before moving forward. The blur has been...

Sorry, I lost track of this. Within the next day or two I'll give this a proper review, but my thinking is that this is a good option to have,...

We may add this at some point, although it is not currently a priority. If someone submitted a PR, we would accept it. In the meantime, a recommendation on Windows...