Luke Chen comments

Results 159 comments of


                                            Luke Chen

KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

@vamossagar12 , I'm fine that we can merge the Persistent StateStores improvement first, and think about custom state store later. But I'm not the one have the right to merge...

KAFKA-14244: Add guard against accidental calls to halt JVM during testing

@C0urante , interesting solution. But I'm wondering how you test it and prove this can really catch `Exit` and report error?

KAFKA-14242: do not init managers twice to avoid resource leak

@hachikuji @jsancio , please take a look. Thanks.

KAFKA-14242: do not init managers twice to avoid resource leak

@divijvaidya , thanks. > I am curious, how did you narrow down that Gradle Test Executor 128 is related to testReloadUpdatedFilesWithoutConfigChange. Did you check the the logs and search for...

KAFKA-14242: do not init managers twice to avoid resource leak

There's been 3 straight builds not get terminated in the `:core:unitTest`.

KAFKA-14242: do not init managers twice to avoid resource leak

cc @ijuma , I think we should merge this fix soon to help our build turn red back to yellow/green light.

KAFKA-14242: do not init managers twice to avoid resource leak

@dajac @hachikuji , FYI

KAFKA-14242: do not init managers twice to avoid resource leak

> @showuon Great find. I am not sure about the fix though, it seems a bit odd to update the mock in this way. To get things back into a...

KAFKA-14242: do not init managers twice to avoid resource leak

@hachikuji , please take a look. Thanks.

KAFKA-14242: do not init managers twice to avoid resource leak

@hachikuji @mumrah , please take a look. Thanks.