Luke Chen

Results 159 comments of Luke Chen

@clolov , there's a compilation error in jdk 8/scala 2.12. Could you help fix it? Maybe rebasing to the latest trunk could solve it? https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15213/4/pipeline

@clolov , do we have any update about the compilation error fix?

@symat @eolivelli , similar to https://github.com/apache/zookeeper/pull/2040 and https://github.com/apache/zookeeper/pull/1524. Call for review. Thanks.

@anmolnar , thanks for the comment. Tests added. Note: It's not easy to test the slow DNS scenario, so I tried to verify the method is invoked as expected, alternatively....

@anmolnar , please take a look when available. Thanks.

@anmolnar , please take a look when available. Thanks.

> @showuon You have checkstyle validation error > > ``` > Error: /home/runner/work/zookeeper/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java:43:1: Extra separation in import group before 'org.apache.jute.OutputArchive' [ImportOrder] > ``` @anmolnar , fixed. Please also help backport...

The compatibility test failed on java 11 in 3.6.3, but passed on java 8 in 3.6.3. I think it should be fine. Thanks.

@eolivelli @symat @tisonkun @ztzg, please take a look when available. Thanks.