Mike Angell
Mike Angell
Plus the point of all this is to achieve that the following code is valid (basically curly brackets inside strings that are inside tags) ``` {{ variable | prepend: '{'...
I'm also starting to wonder if we should solve the few following issues as these can be fixed with a few more tokens to scan for ### Allow escaping in...
An alternative proposal for the changes above is to bring in a third quoting method using backticks ### Allow escaping in ` so that it is possible to use both...
Maybe once this is in we can look at ``` Layout/ExtraSpacing: ForceEqualSignAlignment: true ``` I would be happy if the style guide at least did no spacing or equal spacing...
I tested it on this and agree its the right move. It's too big to apply here so I will do as new PR after this has made it through....
Yeah, it just makes it easier to replace the method. This is just a tiny step to improve things. I've been playing around a bit with replacing `Tag` and `Block`...
Just a comment here to remember, this will likely mess with Tags that extend the core tags.
Yeah, I think it is worth trying and seeing what it looks like. Just make sure it's only loaded for tests, so it can't impact Liquid users.
Why do this? Because it simplifies scopes and environments access to be the same method. This allows for future improvements to optimise the time complexity of lookups across both scopes...
@Shopify/liquid @Shopify/guardians-of-the-liquid @samdoiron this will greatly simplify your new changes as well