liquid icon indicating copy to clipboard operation
liquid copied to clipboard

Published 20 hours ago • verified publisher icon Shopify

Change all constants to SCREAMING_SNAKE_CASE

Open shopmike opened this issue 5 years ago • 4 comments

This changes all constants to SCREAMING_SNAKE_CASE. It provides backward support through liquid/legacy

@Shopify/liquid

shopmike avatar Sep 18 '19 05:09 shopmike

@shopmike If you don't mind, can you align the = operators in the legacy.rb to improve readability? I understand that the contents there are meant for internal use only and for the short duration until Liquid 5.0.. But still... :wink:

ashmaroli avatar Sep 19 '19 15:09 ashmaroli

Maybe once this is in we can look at

Layout/ExtraSpacing:
  ForceEqualSignAlignment: true

I would be happy if the style guide at least did no spacing or equal spacing but it looks like it doesn't do either so might need to set this in the project rubocop. https://github.com/Shopify/liquid/pull/1159/files#diff-1ac8d79c9833db7b503c16989031b253R36

shopmike avatar Sep 19 '19 15:09 shopmike

Why are we not using ForceEqualSignAlignment? Seems like a nobrainer.

tobi avatar Sep 19 '19 15:09 tobi

I tested it on this and agree its the right move. It's too big to apply here so I will do as new PR after this has made it through.

I'd like to get to a point where PR's don't contain styling feedback as the Rubocop config is solid.

shopmike avatar Sep 19 '19 17:09 shopmike