Mike Angell

Results 39 comments of Mike Angell

Hey, @Legic thanks for raising these. I know it's been a long time in the making but I'm currently working on resolving some of these issues. I'll keep you posted.

@Legic I'm happy to announce the issue you have described in #1 has now been implemented with a new `options_by_name` method on products. **Before** ```twig {% for product_option in product.options_with_values...

Sure is, it will be available in the docs next week.

Happy to announce that `options_by_name` is now case-insensitive. So you no longer need to check for `color` when in fact it is `Color` as the method will do it for...

https://help.shopify.com/en/themes/liquid/objects/product#product-options_by_name

@samdoiron regardless of this change, just thinking about this and your static environments. instance variables are going to sit between environments and static environments. I'm not sure if that creates...

Hey, @andymikulski I agree this is would be a cool addition to Liquid. There are a lot of things we are currently working on but would love to think this...

Oh yeah, performance for this is likely, not great at the moment. I was just focusing on getting it to pass. This has the ability to be highly efficient though...

This regex wouldn't exist either, needs to be replaced by a scanner. Just a quick hack to get this moving ``` source.split(/({%|{{|"|'|}}|%}|})/om).each ```

And the conditional statements are double checking things which should be optimised