Prevent needing to squash instance assigns

[shopmike]

Instead of needing to squash instance assigns, we instead just put them at the bottom of the environment stack.

This simplifies the code base and gains extra performance by not needing to loop over scopes and environments.

@Shopify/guardians-of-the-liquid

[tobi]

Smart

On Mon, Sep 16, 2019 at 7:46 AM Mike Angell [email protected] wrote:

Instead of needing to squash instance assigns, we instead just put them at the bottom of the environment stack.

This simplifies the code base and gains extra performance by not needing to loop over scopes and environments.

@Shopify/guardians-of-the-liquid https://github.com/orgs/Shopify/teams/guardians-of-the-liquid

You can view, comment on, or merge this pull request online at:

https://github.com/Shopify/liquid/pull/1155 Commit Summary

• Prevent needing to squash instance assigns

File Changes

• M lib/liquid/context.rb https://github.com/Shopify/liquid/pull/1155/files#diff-0 (12)
• M lib/liquid/template.rb https://github.com/Shopify/liquid/pull/1155/files#diff-1 (10)

Patch Links:

• https://github.com/Shopify/liquid/pull/1155.patch
• https://github.com/Shopify/liquid/pull/1155.diff

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/Shopify/liquid/pull/1155?email_source=notifications&email_token=AAAACW5U3WLMLDX3LAXHLA3QJ5WXXA5CNFSM4IXBD7H2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLR2XYA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAACWYHIOZY6ZQVV6UQWWTQJ5WXXANCNFSM4IXBD7HQ .

--

• tobi CEO Shopify

[shopmike]

@samdoiron regardless of this change, just thinking about this and your static environments. instance variables are going to sit between environments and static environments. I'm not sure if that creates any issues.