shn-srl

Results 10 comments of shn-srl

Fixing failing tests now

PR for test fixes: https://github.com/serlo/frontend/pull/4012

> Nice improvement over the first PR, imo. 👍 > > A couple of suggestions: > > * Rather than rendering the context provider in the `InnerDocument`, render it in...

Sub ticket created https://linear.app/serlo/issue/PE-69/split-filinthegaps-plugin

@elbotho @hejtful Would appreciate another review round :pray: I am conducting a full usability test with Gregor today at 16, and still looking over the tests to ensure nothing is...

> * there is already a discussion about this but right now I can't replace the text-plugin with the new plugin I select, it always get's appended Fixed

> Search bar autofocus doesn't work for me in local, on Chrome. Not sure if you're already on it It works for me in Chromium and Firefox Could it be...

> @shn-srl If you change `onMouseEnter` to `onMouseMove` in `PluginMenuItem`, the bug seems to be fixed. Just a suggestion. Done

Updated the description regarding the tests: Most tests are fixed, flakiness when running locally is making it unsustainable to keep testing locally, as soon as this PR gets merged I...

From Botho: One weird case: When I insert some plugins (e.g. equations & code) with enter I get an additional textplugin below my inserted plugin (I guess the enter propagates)