shmiwy

@Liuheng22 Gradescope works again after I submit that file and gtest_CMakeLists.txt.in (20fall all labs). Thanks very much for your help.

Let me have a try! : )

@skyzh It seems that we don't support primary key? when I type this sql ```sql create table t (a int not null, b int not null, c int, d int,...

Can we add a field called `primary_key_indices` in `TableCatalog` without removng `is_primary `field from `ColumnDesc`? I think we can just change the `new` function for `TableCatalog`(src/ catalog/ table.rs) around these...

By the way, changing the binder to supports this kind of sql query seems easy. ```sql create table t(a int not null, b int not null, c int, d int,...

> But from my perspective, `is_primary` won't be used after we have refactored all occurrences. We can have such intermediate state, and refactor it later. I think it just make...

Or we need to refactor everything that uses the function （more bugs can emerge hhhh🤩）

still not tell difference between primary key(a, b) and primary key(b, a), i will do this int the not-too-distant future.

on the first step, I'm going to add two filed in `TableCatalog.Inner`, one is `pk_ids` which is a HashSet to indicate which columns are primary, the other one is `extra_ipk_ids`....

ok🥳