Shea Levy

Results 136 comments of Shea Levy

https://github.com/shlevy/source-specifications/blob/aafb35d070ba5cec72fbf281ae785310150d0820/src/default.nix#L247-L276 for example

Looks like this is because of modules, a feature I didn't know about https://maven.apache.org/guides/mini/guide-multiple-modules.html I'll take a look when I get a chance, thanks!

I'm not really actively developing mvn2nix currently, I'll review PRs and consider transferring maintainership though.

Possible interaction with flakes: I'd like to be able to have the functions to build a package set in a flake, as well as the ability to declaratively overlay package...

I'd like to nominate @edolstra and myself for the shepherd team

Before reviewing the details, I do have one high level concern. To quote from the [README](https://github.com/NixOS/rfcs/tree/d9aad9291186cc10375afa5aaefed2b01357cf7e#the-rfc-life-cycle): > Furthermore, the fact that a given RFC has been accepted implies nothing about...

I will do a deep review some time next week.

@wmertens There seems to be quite a bit of unaddressed commentary here. Do you want to go through it on your own time, or we can set up a call/chat...