Yuanhao Ji

Results 21 comments of Yuanhao Ji

There are some failed checks in the PR #16003 because of this flaky test, what can I do about this issue?

@poorbarcode Thank you for your suggestions! But the problem is, all failed checks are about this flaky test, it seems that they are not caused by changed code, but they...

I deleted the `build` directory, then it worked.

I got the same error when running this test: ```bash python test/test_mps.py ``` ``` ........./opt/anaconda3/envs/pth/lib/python3.11/site-packages/torch/nn/functional.py:4539: UserWarning: MPS: The constant padding of more than 3 dimensions is not currently supported natively....

@awgu Thanks for your review. I'll add some unit tests.

> > @awgu Thanks for your review. I'll add some unit tests. > > Thanks! unit test can go inside https://github.com/pytorch/pytorch/blob/main/test/distributed/test_device_mesh.py#L53 @wz337 Thanks for guidance! Please check it out: https://github.com/pytorch/pytorch/pull/124390/commits/69620ac7fdb2387b4d9f0d4a056ba47b1071746c

conflicts resolved, see https://github.com/pytorch/pytorch/pull/124390/commits/94b3a9528e104e18d3549ffc289f5f15e02f87da

@awgu @wconstab Please take a look, thank you very much :D

虽然但是,貌似确实有点像

@svekars Sorry for the late reply. I have signed the CLA, please take a look, thanks!