Stephen Hicks
Stephen Hicks
We're more or less moving off of these libraries and encouraging the use of other testing frameworks. If somebody wants to contribute documentation, it would be welcome, but it's pretty...
As an aside, this is pretty reasonable to do in TypeScript: one can [unwrap the promise] easily enough. [unwrap the promise]: http://www.typescriptlang.org/play/#src=type%20UnwrapPromise%3CT%3E%20%3D%20T%20extends%20Promise%3Cinfer%20U%3E%20%3F%20U%7CT%20%3A%20never%3B%20%0D%0A%0D%0Ainterface%20Expectation%3CT%3E%20%7B%0D%0A%20%20%20%20%24returnsAsync(x%3A%20UnwrapPromise%3CT%3E)%3A%20undefined%3B%0D%0A%20%20%20%20%24returns(x%3A%20T)%3A%20undefined%3B%0D%0A%7D%0D%0A%0D%0Adeclare%20let%20foo%3A%20Expectation%3CPromise%3Cnumber%3E%3E%3B%0D%0Afoo.%24returnsAsync(42)%3B%0D%0Afoo.%24returnsAsync(Promise.resolve(42))%3B%0D%0Afoo.%24returns(42)%3B%0D%0Afoo.%24returns(Promise.resolve(42))%3B%0D%0A%0D%0Adeclare%20let%20bar%3A%20Expectation%3Cnumber%3E%3B%0D%0Abar.%24returnsAsync(42)%3B%0D%0Abar.%24returnsAsync(Promise.resolve(42))%3B%0D%0Abar.%24returns(42)%3B%0D%0Abar.%24returns(Promise.resolve(42))%3B%0D%0A
Thanks for reporting this. Do you think you could put together a pull request to implement your workaround?
Do you have a link that explains this property - what browsers is it available under?
Looping back, it looks like the timeStamp property is pretty limited in terms of browser support. If there is a reasonable way to fill it in for `goog.events.Event` (or `BrowserEvent`)...
@tjgq maybe you have some insight into this?
Simply deleting these will not work - we want to keep the internal links internally, so we need to add proper scrubbing directives to them.
Aside from adding even more complexity to an already poor API, I don't know of a specific reason. I'm hesitant to add yet another optional constructor argument to the already-excessive...
The problem here is that there are some slight differences in how the two libraries work - they're not quite drop-in compatible with each other. I think the first order...
Could we change its type to the following? ``` js /** @param {function(this: T, ...*): R} func @param {...*} var_args @return {function(this: T, ...*): R} @template T, R */ goog.partial...