Baodi Shi
Baodi Shi
@RobertIndie @BewareMyPower Thanks for the review, all suggestions have been fixed, PTAL.
/pulsarbot run-failure-checks
/pulsarbot run-failure-checks
/pulsarbot run-failure-checks
@BewareMyPower @RobertIndie Can you look at it again? Thanks.
> I just thought again for the design of `KeyValue`. Currently, for a given `Message` object, > > * the key is stored in the `MessageMetadata` object (generated by ProtoBuf)...
> > I keep encoding type in KeyValue. Because if will remove it, will affect the API. > > The encoding type is already included in the schema, which is...
/pulsarbot run-failure-checks
> Hi @shibd, I've completed my review except some details of tests, PTAL. @BewareMyPower Thanks for your review, I fixed it, PTAL.
Resubmit the PR in pulsar-client-cpp repository: https://github.com/apache/pulsar-client-cpp/pull/22