Baodi Shi comments

Results 98 comments of


                                            Baodi Shi

[feat][cpp] Consumer support batch receive messages.

/pulsarbot run-failure-checks

[feat][cpp] Consumer support batch receive messages.

Resubmit the PR in pulsar-client-cpp repository: https://github.com/apache/pulsar-client-cpp/pull/21

[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

/pulsarbot run-failure-checks

[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

@nodece Thanks, all comments fixed, PTAL.

[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

/pulsarbot run-failure-checks

[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

> It looks like a race condition here. Is it possible to introduce a lock or use the same thread for messageReceived and redeliverUnacknowledgedMessages to resolve the issue? @codelipenghui Seem...

[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

> We should clean up the receiver queue when users invoke the redeliverUnacknowledgedMessages method? Yes, In this way, the epoch can be judged before offer the queue. @congbobo184 What do...

[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

@codelipenghui @congbobo184 I add a new incomingQueueLock to sync (judge epoch and offer incoming queue) and (change epoch and clear incoming queue) code block. PTAL.

[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout.

/pulsarbot run-failure-checks

[improve][client-c++]Support include message header size when check maxMessageSize

Odd, why is the java client compilation failed? https://github.com/apache/pulsar/runs/8033665923?check_suite_focus=true ``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project pulsar-client-original: Compilation failure Error: /Users/runner/work/pulsar/pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java:[222,39] no suitable method found for sendMessage(long,long,int,org.apache.pulsar.common.api.proto.MessageMetadata,io.netty.buffer.ByteBuf)...