Sheheryar Umair

Results 7 comments of Sheheryar Umair

Hey @sjohnr ! Thanks for pointing out this issue in my PR. `dataSource` variable can be empty but not null. So if it is empty then we have to handle...

Hey @sjohnr! Can you kindly review the PR, please?

Hey @sjohnr. Thank you for your review. I have changed to `hasText` and added another test when `data-source-ref` attribute is entirely missing.

Hey @sjohnr ! Apologies for the oversight, I committed the code without running the Checkstyle analysis. I have now corrected the code to adhere to the coding standards and have...

Hey @sjohnr! I have squashed my commits and changed the XML to multi line

Hey @sjohnr . I hope my latest PR solves all the issues.

Hey @sjohnr! Is there anything else that is left on my side?