Neil Henning comments

Results 79 comments of


                                            Neil Henning

Verboser output of child in case of invalid/unknown command

Hey there! Any chance you've got a dumb test case with the output you get with this patch? I just want to understand what is being reported back to the...

Would you accept a PR that added basic iterators?

Eh I never did the PR. I lost steam on what I was using inkwell for, and closed the issued because I didn't wanna be one of those loitering people...

strn/utf8n functions

I think your arguments are probably right the more I've considered this. My hesitation has been that the `n` is generally _used_ in `strn*` functions to say _'hey I only...

Feature Request: set the cwd for created processes

I look forward to the PR!

error: double-'free' of '<unknown>' [CWE-415] [-Werror=analyzer-double-free]

I'm not doubting that this is right - but I **cannot** for the life of me work out how this is possible with the code. Is there anyway that warning...

SPV Remapper: should use SPIRV-Tools binary parser

@steve-lunarg (revisiting an old issue here) - it'd make more sense in my opinion that the functionality of the spirv remapper be moved into spirv-opt as an optimization pass. I...

Just in case you want to keep it upto date

This LGTM on an initial glance, but I'll test it on Windows before merging it (it really frustrates me that I can't build LLVM on appveyor to be able to...

Unicode support on Windows?

If someone wants to put together a PR that passes CI I'd happily accept it.

Stack Overflow in json_get_value_size()

Good find! I'll think on a fix.

utf8makevalid read out of bounds (+ other functions)

Good spot! Would happily accept a PR with testing.