Shazron Abdullah

Results 74 comments of Shazron Abdullah

Planning on it (media query first)….

I tried adding NS_RETURNS_RETAINED to the function headers, the static analyzer still complains. The two warnings are here: 1. https://github.com/johnezang/JSONKit/blob/82157634ca0ca5b6a4a67a194dd11f15d9b72835/JSONKit.m#L682 2. https://github.com/johnezang/JSONKit/blob/82157634ca0ca5b6a4a67a194dd11f15d9b72835/JSONKit.m#L933

GlennChiu's patch is incorrect - you can't free the memory there because in the next line the "init" message is sent to it (that's why it crashes). I finally had...

[email protected] was just published with a fix. Sorry about this, I was away (public holidays)

Looks like the CI failures are paramedic related -- iOS tests pass which is good. I'll have to do a full review based on the new commits and test manually.

This makes sense, but is a backwards incompatible change since the behaviour changes, and some may be using that behaviour. Either: 1. Increment the major version number, document the breaking...