Shawn Allen

Results 66 comments of Shawn Allen

Most of the work here has been done in #47. See that PR for testing instructions. The current test runner is QUnit, but we don't have D3-specific tests yet. The...

Some more tests to include: - [x] test classList shim on SVG elements (see: WebReflection/dom4#10) - [ ] events: at the very least, we should check that HTML elements have...

Hi, I'm actually a huge fan of @WebReflection and have used his v0 polyfill extensively! However, to more closely align with what my teammates at GitHub are doing, I decided...

@jeremiak: I think the best way to do it is with DOM events. You can dispatch [CustomEvent](https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent) instances from your element like so: ``` js this.dispatchEvent(new CustomEvent('change')); ``` Custom events...

That's definitely correct, @msecret. Custom elements should offer progressive enhancement. And I think that for most uses I've had so far, that makes perfect sense because pretty much any dynamic...

@lukasoppermann First of all, I would treat the extra markup as purely progressive enhancement: if your component doesn't load (for whatever reason)—or even just _until_ it does (when the network...

@lukasoppermann Another way to handle that would be to check that its "new" parent is your expected container, a la: ``` js const CONTAINER_CLASS = 'fancy-input-container'; class FancyInput extends HTMLInputElement...

Also, sorry for not responding to your question, @joshbruce! My personal preference (and one that I've raised in 18F/web-design-standards#1526) is to use the HTML standard elements whenever possible, and deploy...

@areinot As far as I know, there's no prohibition on inline event handlers in the [custom elements v1 spec](https://www.w3.org/TR/custom-elements/), so they _should_ work. [Your example works](https://jsfiddle.net/r0gp6Lz8/) in Chrome's native implementation...

One way that we could handle this is to have one or more variables where the URLs of certain images live, so that non-github — or even just uses outside...