Steven Hawkins

Results 508 comments of Steven Hawkins

> This is actually a pretty bad regression, increasing the priority of this. What works: build ... with build time spi options specified start --optimized ... -- without build time...

Thanks @MikeEdgar this looks promising. It does seem highly related to SchemaSwap - at least for the usage of implemenation or type. SchemaSwap could be altered to work at a...

> The swaps are still limited to whatever schema can be obtained from the referenced class(es) using the existing scanning however, correct? That is correct, you can't specify an arbitrary...

> Ultimately the problem with those annotations is that they redirect to another class/type to perform the same scanning logic, so there is no way to specify the schema attributes...

> Would SchemaFrom be more similar to how I described implementation works? Yes SchemaFrom and SchemaSwap do the same thing as what JSONSchema.implementation does via the type and targetType properties...

> The java-generator(in this repo) will not work, and, from a brief look, popular projects like [kubebuilder](https://github.com/kubernetes-sigs/kubebuilder) do not support them too. There's https://github.com/kubernetes-sigs/controller-tools/issues/461 - you can't start from the...

@vmuzikar this is roughly what we talked about. I wasn't sure if we even need to have an env option for bootstrap-admin user username - we can have just the...

> It'd allow either. Plus, if someone doesn't specify neither, they will be prompted. Ok, this now supports either --username or --username:env > Sounds like a good idea. Added a...

@vmuzikar adding bootstrap-admin service account handling as well. Some additional thoughts / questions: - if the user specifies both the env variable for the admin user and service, should we...

> @shawkins Thank you for the PR and sorry for the late review. I think the changes are a good start. > > Added some comments. > > Noticed also...