Steven Hawkins

Results 508 comments of Steven Hawkins

> I also noticed that the `jakarta-mail` dependency version currently is not aligned with quarkus (we use a newer version). Should it be among excluded dependencies as well? Is it...

It's not clear from what you have posted that there is a bug. The watching boolean can be false during the normal operation of the relfector. As long as you...

@andreaTP @bbende this should already be supported by the v2 generator.

You'd have to check with the JOSDK folks, but I don't think they have release yet that aligns to the v2 generator.

> So I'm not sure why that doesn't fail with kubectl and fails with ours. The problem is likely with using Json Patch. If the annotation already exists, then doing...

> Btw, strategic-merge-patch works in both cases Can you test json merge (merge-patch+json) as well?

I think we've determined that the problem will occur when there are no annotations present, in which case a Json Patch add can't automatically add a parent.

@jean-christophe-manciot can you also add a commit signature? After that I think this looks good. We'll see what the other @keycloak/cloud-native think as well.

> Isn't rebasing all my commits with a signature be a problem? As long as the initial commit retains the sign-off we can set the dco check to passing and...