David Peter
David Peter
### JSON format v2 Things to keep in mind / ideas: - We could potentially include the full command line, in order to repeat a benchmark in an easy way...
> I’m a bit conflicted about this. On one hand I agree that having `Time` be the time portion of `DateTime` is reasonable and intuitive. On the other, many physics...
Thank you. I'm not sure this is the best way forward. Spawning a separate thread seems like a big hammer to solve this problem. I was thinking that we could...
Thank you very much for reporting this. This lazy loading of currencies really causes a lot of issues. We've been recently discussing a general lazy evaluation strategy that would potentially...
> Tackling this seems easy enough with a build script that parses `units/currencies.nbt` and emits a Rust array to a file, and then `const CURRENCY_IDENTIFIERS: &[&str] = include!(...)`. Yes. Let's...
Thank you very much. This does not seem to work for me on Linux (using a standard X server with i3). After typing `copy`, I get the expected message: ```...
> Hmm, how about now? (I don't have a linux box to test with.) Now I get an error message (same as in CI: https://github.com/sharkdp/numbat/actions/runs/11258512679/job/31305297678?pr=590#step:8:258), but if I fix that...
> I'm guessing then that using the non-Linux code for Linux should work, at least as long as numbat is running? You mean the state you had before? ([c7b4f89](https://github.com/sharkdp/numbat/pull/590/commits/c7b4f89c0f62d2da41f74db597b6dce2791ecbfc)) No....
Now it works — thank you! I will do a full review shortly. I will already note that I am a bit overwhelmed by the number of configuration options. I'm...
> `max-sig-digits`, `min-sig-digits`, and `max-width` can probably all go. The rest I feel are important to keep, though. If it's not too much trouble, it would be great if we...