David Peter
David Peter
Yes, thank you for reporting this. I think we should probably catch this, but in general, we won't be able to turn all calculations that potentially return `inf` into runtime...
Thank you very much! I'll review this soon.
I like this very much. Can we please re-implement the existing functions `DMS`, `DM`, `feet_and_inches` and `pounds_and_ounces` in terms of your `unit_list` function and get rid of the existing String-based...
I think the (Numbat-based) tests for DMS/DM/… need some adaptations from the string-based format to the list-based format.
Oh, it looks like you don't use utf-8 as a default system encoding (but `cp1252` instead, similar to Latin-1). Can you please try to add a `encoding="utf-8"` argument to all...
Oh yes, sorry. You need `mdbook` installed (https://rust-lang.github.io/mdBook/guide/installation.html). We should improve the error message there. Please let me know if I should simply generate the documentation for you.
Thank you very much for the updates. I added an `@example` for `unit_list` (something that became possible recently), fixed how DMS/DM were displayed, and replaced `foldl(_add, 0)` by the `sum`...
One thing I thought about was whether the implementation of the `human` function could profit from `unit_list`. Maybe worth checking out.
> Seems like it is running a different version, as currency conversions (at least) don't work. E.g., ` 1 eur to gbp` fails in the online editor. Not a different...
Do you use a release build of Numbat? 560 ms seems very slow. I see something like 135 ms (which is still quite slow, maybe we should investigate why the...