Sharif Elgamal

Results 11 comments of Sharif Elgamal

Testing instructions out of date

I think the goal will be to remove the Makefile completely. Just need to change how the travis tests are run and update the README.

Moving minikube hyperkit changes upstream

I've verified that it works with `minikube` and `docker-machine` is documented as not working with hyperkit.

docker-machine tweaks in support of PR #13

This has been tested and works with minikube as well. I'm would be happy for this to get merged and to abandon my PR.

refactor: avoiding repetitive code

The VM boolean for driver choice is necessary, so we can filter out non-VM choices (none, docker) when `--vm=true` is passed into `minikube start`

minikube host IP incorrect if not 192.168.64.1 - minikube mount fails

This strikes me as a legitimate bug in our mounting code.

minikube host IP incorrect if not 192.168.64.1 - minikube mount fails

We'd be happy to review a PR that detects this proactively.

Remove experimental markings from QEMU driver

😱

SSH driver: --ssh-user argument seems to be ignored

cc @afbjorklund

SSH driver: --ssh-user argument seems to be ignored

I'll freeze this so it doesn't go stale while someone looks into it. Help wanted!

`minikube mount` does not follow symlinks

A lot of the issues we've experienced with auto-mounting comes down to issues with 9p, which we can't really do much about. We've explored other options for mounting, but haven't...