Shargon

Results 653 comments of Shargon

You need to add the checksum at the end `Base58CheckEncode` is not only a Base58, you can see the logic here: https://github.com/neo-project/neo/blob/7b24f8efaf752e0eb64eaa258a0b29f6359194be/src/neo/Cryptography/Base58.cs#L26-L35

I think that this is a good idea, but oracle can't use it because they don't provide the original transaction, only send the signatures in order to avoid the lazy...

We can create a new message type, incomplete message, type, content and current signatures. Then it's possible to create a plugin in order to collect the specific messages an relay...

I think that we can use https://github.com/neo-project/neo/pull/2101

How big it's your cache? It's a FIFO cache?

What about replace `if (MemPool.ContainsKey(hash)) return true;` with `if (KnownHashes.ContainsKey(hash)) return true;` It is a cache and it is updated

> I have no idea what's going on inside of it and usually I'm just using CalledByEntry because it's the simplest thing to do and it works. Until it doesn't....

https://github.com/neo-project/neo/issues/2772#issuecomment-1163554219

What's the sense of remove the seedlist but not the `StandbyCommittee`? I think that we should remove all and ensure that it's configured by the json