ScottH

Results 41 comments of ScottH

Hi @kangarooo, Multipass only guarantees support for changing settings of vms as we provide access to them (see [modifying an instance](https://multipass.run/docs/modify-an-instance#heading--set-the-cpu-ram-or-disk-of-an-instance)), so we cannot predict the behavior of Multipass after...

Hi @JCzz, thanks for putting in some time to debug this! We will take a deeper look into this once we get the chance. Or, if you end up finding...

Hi @johnnygerard, It looks like something else is conflicting with Multipass, hence the need to restart the daemon on every system restart. Does reinstalling Multipass resolve the issue or can...

Ok, still a few outstanding things, but I'm pretty much ready to give my approval. I think @ricab wanted to also give this a once over as well. I have...

In response to your architecture discussion points: For No.1, I think the current name generation pattern is fine. No need to over complicate at this point as it isn't crucial...

Hey @andrei-toterman, The idea of the BackInserter was so that insertions could be made into the returned vector from either an existing vector (as used in `vm_mount`) or from a...

Yes, I had considered that. For the some of the "errors" that can happen when creating mounts (eg. incorrect paths, incorrect instances name) we simply ignore those items and continue...

@andrei-toterman Thanks for the review! I think I've addressed all your comments.

Hi @andrei-toterman, The reason I put it on the same line was to stay consistent with launch errors: ``` $ multipass launch docker launch failed: Downloaded image hash does not...