Sean Hanson

Perhaps even easier (more useful?) an option to keep the tags of the dividend for these functions, rather than strictly overlapping tags.

> What do you mean "trash the tags of the inputs" ? Tags go in but they don't come out. > Maybe add some useful example which can be used...

> Example input, current output, desired output ? Haha, yeah I meant what format do tests take for series/tags. I'll dig it out of the code.

Ok so let's say we have 2 input series representing the number of requests and the total time taken (divisor and dividend respectively): ``` divisor.name = 'requests.count' divisor.tags = {...

> My suggestion would be that by default all tags of the dividend series should be propagated, along with a new tag to be consistent with the behavior of other...

We have been using tags for a while now, so I expect many dashboards currently "work" with the existing behavior. I expect many of those will be negatively impacted by...

> I note that divideSeries, divideSeriesList and asPercent functions are not tag aware. they simply match dividends and divisors in the order they were provided, without regard for which tags...

I'm still a little worried about changing this behavior backwards incompatibly, since I'm not sure where we will be impacted. However, creating a new `divideByTags` or something with straight-forward tag...

> assert that the list of join keys is not empty. error otherwise What if you want to divide a number of input series by a single tag-less series (e.g....

This could be considerably more expensive to do at read time. Think about something with ten nodes, each node cardinality ten. Just thinking about doing a DFS on the initial...