Shannon Booth

Results 45 issues of Shannon Booth

Draft on top of https://github.com/SerenityOS/serenity/pull/19455 as otherwise would have conflicts in LibWeb's Forward.h These set of changes aim to implement the `optional QueuingStrategy strategy = {}` argument in the constructor...

👀 pr-needs-review

The `readonly attribute Function size` is still left to be implemented for these interfaces.

👀 pr-needs-review

I have been trying to implement tests for the Web::Blob::stream implementation. Due to the async nature of streams, it seems to currently be not possible to add text tests for...

enhancement

This is sitting on top of https://github.com/SerenityOS/serenity/pull/19530, draft until that is merged.

This is still very bare bones, and there is _much_ more to still handle. However, this implements enough functionality to parse a single unified patch read from stdin, and apply...

⏳ pr-waiting-for-author

When `git` port is installed and editing a git repository, HackStudio will frequently crash at https://github.com/SerenityOS/serenity/blob/9430bbcc627048ee3a3eb051561739415c247f81/Userland/DevTools/HackStudio/Editor.cpp#L104 When changing a file in that git repository. A big part of the issue...

bug

Per: https://dom.spec.whatwg.org/#concept-reflect We should be calling `get_attribute_value` for reflected IDL strings. No functional change as nowhere is performing a reflect on a nullable type, and just ends up simplifying the...

👀 pr-needs-review

We were previously defining it in each TypedArray derived class as their own function instead of allowing it to be inherited from the TypedArray constructor. Diff Tests: +4 ✅ -4...

👀 pr-needs-review

In LibWeb the internal string representation is in UTF-8, but to the outside world this is exposed as UTF-16. For performance, it would be advantageous to have some sort of...

enhancement
performance

I have also tried running through the test suite, but it unfortunately seems to cause a kernel panic.

👀 pr-needs-review