Shannon Booth

Results 23 comments of Shannon Booth

While implementing ByteLengthQueuingStrategy size algorithm found a bug in my `ExtractSizeAlgorithm` AO implementation by mistakenly passing through `chunk` as this value rather than as an argument. Everything works good after...

Pushed rebase after merge of https://github.com/SerenityOS/serenity/pull/19455

Suspect fix may be somewhat similar to what is done in: https://github.com/SerenityOS/serenity/pull/19843

> First, you have a bug in that you will end up with a list of code points, and not a string, in result. But that's not the issue. Yeah,...

> @alimpfard I guess the thing to do here is to rename DeprecatedFlyString to FlyBytes or some such? > > (As-is, the rhs has very different performance characteristics than the...

![image](https://github.com/SerenityOS/serenity/assets/35911232/be71c665-ef68-4e1a-9c9a-2bfe96ef8c5c) Looks like it is working for me - although login is problematic for me still.

I've investigated it somewhat, and it seems that this crash started happening after: 2505cecc0f6d8b70b21952c30ee1f885c67debd8 Now just trying to resolve my confusion about where the spec is meant to align these...

One tricky part about this that I ran into previously with this is that LibCore depends on `AK/URL.h`. Adding that dependency should be _ok_ right now (and doesn't change the...

> I hate having to ask this bluntly, but is there any actual purpose in this? Projects made by contributors are always nice to see, and some (like e.g. `citron`)...

> This is a bit of a tangent, but while poking around, I noticed that Serenity's patch implementation is also written by you. 😆 Is there much of a difference...