Andrew Shankie

Results 33 comments of Andrew Shankie

Looks the same as my stuff @PaoloDiBello – just passing additional props to the underlying component. @BosNaufal can we get these little tweaks merged?

No, I'm not sure I'm sorry

Yes @nwinch that's exactly what I was thinking. In the end in my use case I didn't end up needing it as I ended up using Auth0 for both the...

Hmm that is a tricky question of how to split them. What do you mean by the idea of a 'reserved env bar'? I'd be keen to hear @motdotla 's...

(Disclaimer – I don't know TypeScript, but this looks like a pretty vanilla JS change anyways)

Oh and obvs I could do this in my reducer, but I think it's tidier to do all the main switching on actions.

Fair enough @mikestead . As you say, adding middleware to inspect all actions for errors is a good idea. I'll run with that. Cheers

Hey @mikestead I only just noticed @jedrichards comment. This is basically my feeling as well. I appreciate the FSA approach, but I think the idiomatic Redux approach would be more...

Yep that makes sense to leave the current as the default @mikestead I'd be happy to help add this when we've got a new project that we're going to base...