react-file-base64 icon indicating copy to clipboard operation
react-file-base64 copied to clipboard

Adds `accept` prop

Open shankie-codes opened this issue 6 years ago • 9 comments

I need to be able to control which file types the component accepts. I've added a passed-through accept prop.

shankie-codes avatar Mar 07 '19 06:03 shankie-codes

Great thanks. Let me know when you've released a new version!

shankie-codes avatar Nov 25 '19 11:11 shankie-codes

I am not the maintainer, so, unfortunately, I can't release a new version. My bad.

PaoloDiBello avatar Nov 25 '19 11:11 PaoloDiBello

Oh. Fair enough!

On Mon, 25 Nov 2019 at 11:23, Paolo Di Bello [email protected] wrote:

I am not the maintainer, so, unfortunately, I can't release a new version. My bad.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BosNaufal/react-file-base64/pull/18?email_source=notifications&email_token=AAT45XUISFVKINFKHH53QPDQVOYTLA5CNFSM4G4J4VZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCB4XY#issuecomment-558112351, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAT45XSI7LD7Q2YBXE743HDQVOYTLANCNFSM4G4J4VZQ .

-- Andrew Shankie +44 (0)7843616844

Proper Design 1 Fox Lane, Cardiff, CF24 1JN +44 (0) 292000 4234

shankie-codes avatar Nov 25 '19 11:11 shankie-codes

Would you mind reviewing my pull requests too? It looks almost like yours but I added disabled instead.

PaoloDiBello avatar Nov 25 '19 11:11 PaoloDiBello

The props could be pass directly like this: <input {...props}>

PaoloDiBello avatar Nov 25 '19 11:11 PaoloDiBello

Looks the same as my stuff @PaoloDiBello – just passing additional props to the underlying component.

@BosNaufal can we get these little tweaks merged?

shankie-codes avatar Nov 25 '19 14:11 shankie-codes

Why not, do you know how?

PaoloDiBello avatar Nov 25 '19 14:11 PaoloDiBello

No, I'm not sure I'm sorry

shankie-codes avatar Nov 25 '19 15:11 shankie-codes

Such a prop would be very useful. @BosNaufal is it planned to merge the changes?

shadrina avatar Jan 12 '20 23:01 shadrina