Shane Utt

Results 578 comments of Shane Utt

I could use some help in verifying this solution according to the problem that was seen in https://github.com/Kong/kubernetes-ingress-controller/discussions/2831.

We have this in `v2.7.0`, but the reason this became a gated feature previously had to do with not wanting any surprises on upgrade (e.g. routes all change right during...

> I do agree with your concerns and I believe there's a middle ground to be met here: require approval from a maintainer every time there's a PR from an...

Sorry the close was unintentional :facepalm:

> > I don't think that the gate for whether someone can exfiltrate our docker credentials should be as simple as whether someone clicks a button to allow the tests...

> This looks like a passable approach to me, if it works, that's even better. Thank you. I have tested this locally and it works. **However** I _have yet to...

Yes, also sounds like something that would be potentially good to do as part of the upcoming `ingress2gateway` migration tool (that is, to document using this tool to migrate potentially).

@jrsmroz you'll need to sign the CLI, and then /lgtm

This has been the source of quite a bit of discussion before, even fairly recently. Probably would be good to check back in on it cc @robscott & @youngnick

I'm glad you brought that one up Rob, as that's been one on my mind as well. Right now I would personally characterize `Accepted` as also meaning `Reconciled`, at least...