Shane Celis
Shane Celis
I have made a change like this myself but wasn't happy about losing the string ergonomics. With this patch, you have to specify whether you're using `.bytes()` or `.chars()` for...
This is looking good. I really like that this doesn't interfere with the using the API with strings. I think the type annotation on builder is a fine concession. One...
I think changing "postfix" to "suffix" is good. Perhaps we can reconsider some of our search names as well. Might as well bundle up the breaking changes. I'm not requesting...
I like the idea of refining the API so that it has options like you suggest. I'm also ok with maybe dropping postfix_search. I'm not sure it had a real...
What does `.labels()` do? And what is returned without `.labels()`? Is it a performance regression?
You've got to think of it in the context of tab completion, where what you want is to solicit the user for which branch to follow. Perhaps `longest_prefix_or_match()` would be...
> Probably just ".shortest()", but that doesn't provide enough information for a top-level API method. Maybe "shortest_suffix"? ("shortest_suffix_or_match" would be more precise, but that's too long IMO) I see. You're...
By the way, I should of said this from the start, but I really like your PR's set of checkboxes that shows the intent and progress. I think I'm going...
> * By "Path", I'm thinking along terms in graph theory. I'm fine with path being used consistently in the library. I just hope not to expose the user to...
> I'm tempted to merge set::Trie and map::Trie, since it would simplify implementation so much. I'm actually really happy you mentioned this. This library was originally built off of `set::Trie`...