Shan E Ahmed Raza

Results 47 comments of Shan E Ahmed Raza

> Should the argument `ignore_is_tiled_tiff` be also part of the `__init__()` method of the `WSIReader` class? The best way would be automatically identify metadata from the file and then read....

The test file is uploaded to https://tiatoolbox.dcs.warwick.ac.uk/sample_wsis/ventana_sample.tif You can update `https://github.com/TissueImageAnalytics/tiatoolbox/blob/develop/tiatoolbox/data/remote_samples.yaml` to add this for tests.

> @shaneahmed I added the file to the registry. I do not think Ventana scanners always output `.tif` files. I think it was just set up like that for us....

> I tried adding the new slide to the fixture list with `OpenSlideWSIreader` as the expected reader: > > ```python > ... > { > "reader_class": OpenSlideWSIReader, > "sample_key": "ventana-tif",...

> **All tests pass with this change.** But this change resulted in some failed ruff checks - the `WSIReader.open()` becomes too complex. So I used `git commit --no-verify` so you...

> Just replacing the old code with your proposed code results in the following error: > > ```shell > ========================================================================================== FAILURES =========================================================================================== > __________________________________________________________________________________ test_tiled_tiff_tifffile ___________________________________________________________________________________ > > remote_sample =...

> ```python > if openslide.OpenSlide.detect_format(input_path) is not None: > ``` OpenSlide will still be able to open regular tiff which is not a WSI. In this case, metadata will be...