shamoon
shamoon
This repo has been quiet for some time and pdfjs is pretty far behind now. Hoping the project does get revived but unclear. If moving to 4.x is not on...
Yea, we ended up internalizing this package and upgrading pdfjs to 3.x but 4.x has so many breaking changes it'd be a lot of work to migrate. Hasn't been a...
Updating this project to pdfjs 4.x is going to require a lot more than just the changes in that commit to actually work, I think. Before 4 came out I...
Thanks, docs are very sparse so I wasnt sure. Looks like it's in DocumentInitParameters https://mozilla.github.io/pdf.js/api/draft/module-pdfjsLib.html . Your suggestion would indeed default it to true but not force it to, I...
The pr is linked above.
Thanks for the PR! Before we get to the implementation questions, I think the first question really needs to be answered. That said, I’m not sure what the definitive answer...
Oh yea I hadnt looked that closely, thought it would be optional in terms of requiring the settings (`settings.DEEPL_TOKEN`, etc). Agree it should absolutely be opt-in. I do have some...
One note in the meantime, I’d be careful about package bloat for what is an optional feature at the moment. I haven’t looked at either of the two mentioned ones...
Sigh. I know what the issue is, will have to figure out a workaround.