Said Abou-Hallawa
Said Abou-Hallawa
#### f04aa1bb640f693204ab6d1b0b1360e0c37cb459 REGRESSION(/276827@main): Large animated images are always decoded asynchronously https://bugs.webkit.org/show_bug.cgi?id=278593 rdar://134597661 Reviewed by NOBODY (OOPS!). The large animated images should be decoded asynchronously if the setting AnimatedImageAsyncDecodingEnabled is true....
#### 853ddb6f76a1413885c798f3b483f3cb55050975 Filters should be applied to detached and non document based canvases https://bugs.webkit.org/show_bug.cgi?id=277638 rdar://133225882 Reviewed by NOBODY (OOPS!). Parsing the filterString should not assume the canvas is attached to...
https://github.com/WebKit/MotionMark/issues/66 The current implementation of the regression calculation has these flaws: When processing (x[0], y[0]), L1 must be any line through (x[0], y[0]) which meets L2 at a point (x’,...
Currently we have these class 1. benchmarkController 2. benchmarkRunnerClient 3. BenchmarkRunner 4. BenchmarkRunnerState 5. ResultsDashboard 6. ResultsTable 7. DeveloperResultsTable benchmarkController and benchmarkRunnerClient are extended a little bit more for the...
``` result[Strings.json.score] = Statistics.geometricMean(testsScores); ``` can be ``` result[Strings.json.score] = Math.geomean(testsScores); ``` And ``` var colorStopStep = Utilities.lerp(gradientStep, -.1, .1); ``` can be ``` var colorStopStep = Math.lerp(gradientStep, -.1, .1);...
This is sometimes confusing and hard to read. ```` this.size = new Point(randSize, randSize); this.minPosition = this.size.center; ``` Can be ``` this.size = new Size(randSize, randSize); this.minPosition = this.size.center; ```
``` this.element = Utilities.createSVGElement("image", attrs, xlinkAttrs, stage.element); ``` can be ``` this.element = document.createSVGElement("image", attrs, xlinkAttrs, stage.element); ``` And ``` var row = Utilities.createElement("tr", {}, this.element); ``` can be ```...
Do not use the string table to access the structure's members. For example: ``` this._results[Strings.json.version] = this._version; ``` can be ``` this._results.version = this._version; ```
Get rid of `SimplePromise` and use the system `Promise`. Use the `await` and `async` syntax to make the code more readable.
The current implementation of the regression calculation has these flaws: 1. When processing (x[0], y[0]), L1 must be any line through (x0, y0) which meets L2 at a point (x’,...