MotionMark icon indicating copy to clipboard operation
MotionMark copied to clipboard

Have better names and purposes for the Benchmark classes

Open shallawa opened this issue 1 year ago • 0 comments

Currently we have these class

  1. benchmarkController
  2. benchmarkRunnerClient
  3. BenchmarkRunner
  4. BenchmarkRunnerState
  5. ResultsDashboard
  6. ResultsTable
  7. DeveloperResultsTable

benchmarkController and benchmarkRunnerClient are extended a little bit more for the debug page. It is hard to know what each class is doing. Extending the class for the debug page seems old-fashioned as well.

I would suggest the following hierarchy:

  1. Motionmark: this acts like the app class. It detects the screen orientation, the frame rate and decides the best stage size. It shows the test frame and calls the Benchmark to run the tests and then it collects the results
  2. Benchmark: It runs all the test by loading the test frame, collecting the results and removing the test frame
  3. Results: It holds the results of running the tests. It is generated by Benchmark and consumed by MotionMark
  4. ReleaseMotionmark: a super class of MotionMark
  5. DebugMotionmark: a super class of MotionMark
  6. DebugReults: a super class of Results
  7. DebugRampResults: a super class of DebugResults
  8. DebugFixedResults: a super class of DebugResults

shallawa avatar Sep 11 '24 16:09 shallawa