Ángel Guzmán Maeso
Ángel Guzmán Maeso
@jgniecki could you try this with master version and confirm if it is reproducible? Thanks
> Just read this to have a confirm : [9234911#comments](https://github.com/markitosgv/JWTRefreshTokenBundle/commit/9234911ebcfe9d67b8f2650e41472c89ce2e89a7#comments) You are welcome to sent PR updates with the docs
@AntoineDewaele I think that could be useful. If you can sent a PR probably others could use it too
> > ``` > > * Updated `@phpstan-param` docblock in `MenuManipulator.php` to allow `object` types in traversables and arrays, improving type safety for menu items. > > ``` > >...
> I think you're trying to solve too many problems at once. Running static analysis on the tests might be a good idea by itself, but let's not combine it...
> > Adding |object will allow pass the phpstan error. In this case I don't know another way to resolve this, but it is only affecting to phpstan side. >...
> As I don't know what phpstan warning you are trying to fix, I cannot provide alternative fixes. Please provide the warning being reported. Full list of errors that I...
@stof @garak @derrabus All reviews are completed and checked now in this one. Waiting new input or merging. Thanks
> ping the min PHP version (which is what this PR actually does, even if it tries to describe it as if the changes in the CI w ok, but...
> what is the benefit it brings us ? Support only PHP versions which are not EOL, and avoid maintain code for old versions.