KnpMenu icon indicating copy to clipboard operation
KnpMenu copied to clipboard

feat: update worflow and composer to PHP 8.2 or upper

Open shakaran opened this issue 3 weeks ago • 5 comments

Based in comment https://github.com/KnpLabs/KnpMenu/pull/351#issuecomment-3631557567

Updates the minimum required PHP version for the project from 8.1 to 8.2.

The changes ensure that all build jobs, dependency management, and code analysis workflows are aligned with PHP 8.2, and the composer.json file now enforces this new requirement.

PHP version upgrade:

  • Updated all relevant job configurations in .github/workflows/build.yaml to use PHP 8.2 instead of 8.1 for builds, dependency checks, and Symfony compatibility tests.
  • Changed the PHP requirement in composer.json from ^8.1 to ^8.2, enforcing the new minimum version for dependency management.

shakaran avatar Dec 09 '25 11:12 shakaran

The workflow changes done in the other PR were not about bumping the min PHP version (which is what this PR actually does, even if it tries to describe it as if the changes in the CI workflow were the important part).

stof avatar Dec 09 '25 12:12 stof

ping the min PHP version (which is what this PR actually does, even if it tries to describe it as if the changes in the CI w

ok, but are you agree in bump min version of php?

shakaran avatar Dec 09 '25 12:12 shakaran

what is the benefit it brings us ?

stof avatar Dec 09 '25 12:12 stof

what is the benefit it brings us ?

Support only PHP versions which are not EOL, and avoid maintain code for old versions.

shakaran avatar Dec 09 '25 12:12 shakaran

And this brings no benefit regarding the maintenance of code for old versions, as there is nothing being removed in term of code, so the maintenance cost is exactly the same than before.

stof avatar Dec 09 '25 13:12 stof