Marcin Hajder
Marcin Hajder
> This is awesome! I love this! Nice work! Thanks :) > 1. This sample uses glfw for its windowing library. I'm OK with this personally, and it's used for...
> 1. This sample uses glfw for its windowing library. I'm OK with this personally, and it's used for other Vulkan samples, but the OpenGL samples in this SDK currently...
Applied corrections related to change requests from #124 and modifications related to #131
> This adds additional coverage for `clEnqueueCopyBufferRect`. > > Should we add additional coverage for `clEnqueueReadBufferRect` and `clEnqueueWriteBufferRect` also? If this is something we want, it's fine to add it...
> > This adds additional coverage for `clEnqueueCopyBufferRect`. > > Should we add additional coverage for `clEnqueueReadBufferRect` and `clEnqueueWriteBufferRect` also? If this is something we want, it's fine to add...
> @shajder is this ready for review? I see you removed the "focused review" label - thanks! yes - it is ready for review. I removed the label "focused review"...
> `VUID-vkGetImageSubresourceLayout-mipLevel-01716(ERROR / SPEC): msgNum: -1906823971 - Validation Error: [ VUID-vkGetImageSubresourceLayout-mipLevel-01716 ] Object 0: handle = 0x90c9290000000714, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0x8e582cdd | vkGetImageSubresourceLayout(): pSubresource.mipLevel (1) must be...
Below is the proposition for a work plan on `cl_ext_float_atomics` and a few questions, I will appreciate discussions and your answers, thanks! 1. Adaptation of `c11_atomics` test suite in order...
> Have you given any thought how to handle this issue? Have you evaluated how other testing frameworks solve this problem? Thanks, I went through `vk-gl-cts` modifications related to `VK_EXT_shader_atomic_float`...