Marcin Hajder
Marcin Hajder
I see the error from windows build: ``` (Link target) -> emulate.obj : error LNK2019: unresolved external symbol _clGetDeviceInfo@20 referenced in function "public: static struct _cl_semaphore_khr * __cdecl _cl_semaphore_khr::create(struct _cl_context...
> Thanks! Would you be able to provide some more details on what corrections were made here? I see a few changes to the testing scope, but not sure if...
@svenvh FYI: the same problem with skipped vector cases applied to this PR as well, I've corrected it but you may want to review again, thanks.
> CL_INVALID_SEMAPHORE_KHR is an error code. Define an invalid property local to the test, this is not correct usage of the macro @joshqti thanks, do you have other values on...
> Per Joshua's comment, using CL_INVALID_SEMAPHORE error code as a property value is confusing. Ben suggested two options corrected according to mentioned suggestion
Based on previous discussion and spec investigation below is a work plan to extend the current framework of printf tests. I will appreciate any suggestions and corrections: New set of...
Thanks for your feedback! > Have you considered doing this unification/refactoring in a new pull request on its own? I would recommend doing so. yes, I think I have specific...
> We are having trouble testing and verifying this PR. Could this PR be split into two changes, one for the code refactoring and the other for enhancing fp16 coverage?...
> I just created an `fp16-staging` branch, as we discussed. If this PR is retargeted at this branch I will merge it, also as we discussed. @bashbaug I've created new...
This PR was merged to main branch along with #1975, closing