Shafreeck

Results 25 comments of Shafreeck

cetcd use redis's sds to handle string. It is supported to write binary. Do you have more details?

@YuleiXiao In fact, you can pass a cetcd_string as the parameter. It is actually a sds type.

@thkukuk Yeah, you are right. I will think about how to support binary safe string

What would happen when `100 Continue` is disabled on large value ?

Sorry for my late reply. It looks good to me. Please send me a pull request if you will.

There is some problem with your code above ##### First > cetcd_watcher\* watcher = cetcd_watcher_create(&m_cli, getKey1(), 0, 1 , 0, handleEvent1, NULL); > cetcd_multi_watch_async(&m_cli, &m_watchers); The `watcher` should be add...

@YuleiXiao > In cetcd_multi_watch_async_stop, I see the code just stop thread, not recycle watchers. Yes, you are right, sorry I made a mistake. However, `cetcd_multi_watch_async_stop` may cause some memory leaks...

@YuleiXiao I did some test and found that it is because the watcher's curl handler has been added to mcurl in `curl_multi_watch` ``` c for (i = 0; i <...

LGTM Please move this issue to LGT2 if you finish the review.