Sameena Shaffeeullah

Results 19 comments of Sameena Shaffeeullah

This feature has now been released by Cloud Storage

@neilstuartcraig what version of the library did you upgrade from when you saw this issue?

Tagged as external because this is an issue with `node-fetch` / `teeny-request`

@frankyn i think this system test is failing because it's not returning the `'x-goog-stored-content-encoding'` header. is that supposed to happen automatically?

> I think we need some integration tests to associate with the new behavior There are already integration tests associated with this new boolean. False case: https://github.com/googleapis/nodejs-storage/blob/0845525a9aebd94da92882ace4cd29bf125641a2/system-test/storage.ts#L2181 True case: https://github.com/googleapis/nodejs-storage/blob/0845525a9aebd94da92882ace4cd29bf125641a2/system-test/storage.ts#L2148...

> One last nit, @shaffeeullah, this will be blocked until the header is no longer allowlist required. @frankyn What is the timeline for that?

@frankyn says this is launched, clear to merge

Hi @anantakrishna , This is done on purpose. We don't believe it is good practice to validate the data returned by the server. The way this is currently implemented, the...

Hi @anantakrishna while I agree that these are strong advantages of including typing for `Metadata`, I still believe that the disadvantages are more impactful. - If we add typing, users...

Hi @fmmoret , This is a fair suggestion. We will consider implementing this. It isn't a breaking change and will allow users to access new GCS metadata fields without upgrading...