Serj

Results 19 comments of Serj
trafficstars

Hi guys. Any news regarding the ticker building using the `SubscribeToExchangeDeltas` WebSocket? I would like to switch from the heavyweight API calls to the WebSockets and make some more available...

@ChrisPulman oopsie, I'm sorry. I have forgotten to add `IApiResponse` interface to the `ApiResponse` class. Added here: https://github.com/reactiveui/refit/pull/1672/files#diff-092434a9c47d4491a15166652006ca2e0263b01b63c2029aa8653e165bfa543bR32 All tests are green now locally ![image](https://github.com/reactiveui/refit/assets/6978458/02bb80a7-0bbd-4ba5-af2c-7cf41986d562)

@ChrisPulman did you have time to check how analyzer react on `new T? Content` property? I have tried to set target `net6.0,net7.0` for Refit itself in order to check how...

@ChrisPulman Unfortunately it's not something you can easily test with unit testing. It's about null-state static analysis. You can find explanation here: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/attributes/nullable-analysis#helper-methods-membernotnull-and-membernotnullwhen I have also prepared the sample you...

My idea was to add `IApiResponseBase` and extract `IsSuccessStatusCode` property from the base interface in order to be able to add attributes over `IsSuccessStatusCode` in each implementation. AFAIU these attributes...

I have this issue in 1.15.1 1.11.0 and 1.13.1 work great ![Image](https://github.com/user-attachments/assets/e25fe315-615d-4481-ba44-6ea8348c3aba)

Hi @timosnel, nice catch! Yes this is one of the expected problems with the `new` keyword. Moreover Moq mixes inheritor and base properties showing them on the same level (1)...

Another idea is to use custom `class TestApiResponse` implementation and mock this class instead