Søren Gjesse

Results 21 comments of Søren Gjesse

Seeme like this is caused by a missing dependency on `androidx.lifecycle`. See https://issuetracker.google.com/230454566#comment4 for details.

On the use of `com.google.errorprone.annotations.InlineMe` in `InstrumentationRegistry`, I have just filed https://issuetracker.google.com/260089912, where R8 will fail on missing classes when processing this library.

_Removed [Type-Defect](../labels/Type-Defect) label._ _Added [Type-Enhancement](../labels/Type-Enhancement), [Area-Language](../labels/Area-Language), [Triaged](../labels/Triaged) labels._

From the stack trace it seems like `com.onesignal.OSNotificationController.setupNotificationServiceExtension` is using reflection to create an instance of a class (through `java.lang.Class.newInstance`). For any use of reflection in code where R8 is...

Isn't it then just the keep rule missing keeping the no-args constructor? ``` -keep class ** implements com.onesignal.OneSignal$OSRemoteNotificationReceivedHandler { (); void remoteNotificationReceived(android.content.Context, com.onesignal.OSNotificationReceivedEvent); } ``` The exception _java.lang.InstantiationException: java.lang.Class has...

@iballan If you have the keep rule ``` -keep class my.package.NotificationServiceExtension { *; } ``` then the class `my.package.NotificationServiceExtension` and all its members should be kept. If that does not...

That sounds like the configuration is not correctly passed to the compiler. Could you try to add the following rule: ``` -keep class * { *; } ``` That should...

@tajchert, are you doing reflection into classes in the OneSignal SDK? If not then library has consumer keep rules defined in `OneSignalSDK/onesignal/consumer-proguard-rules.pro` - please check if these are included by...

As an FYI, this is the retraced stacktrace: ``` Caused by: com.android.tools.r8.jetbrains.kotlinx.metadata.InconsistentKotlinMetadataException: No VersionRequirement with the given id in the table at com.android.tools.r8.jetbrains.kotlinx.metadata.InconsistentKotlinMetadataException.(InconsistentKotlinMetadataException.kt:8) at com.android.tools.r8.jetbrains.kotlinx.metadata.impl.ReadersKt.acceptVersionRequirementVisitor(readers.kt:424) at com.android.tools.r8.jetbrains.kotlinx.metadata.impl.ReadersKt.accept(readers.kt:251) at com.android.tools.r8.jetbrains.kotlinx.metadata.impl.ReadersKt.accept(readers.kt:201) at...

FYI @ahumesky, @timpeut and @lizkammer well.