Sarah Gibson
Sarah Gibson
I updated the issue body with some action items and a definition of done based on my investigations and discussions with the team today.
- Netlify requires a new project per language atm - @da5nsy checking Netlify forum in case there's a more sensible way to do this - pt project is turned off...
@JimMadge are you suggesting an extra link-checking step to the one we already run [here](https://github.com/alan-turing-institute/the-turing-way/blob/58980d7f5b03d3165a3fe6defd1f38957c916911/.github/workflows/ci.yml#L31-L35)? The problem with checking for dead links in the markdown is that won't actually catch...
> I suppose the question then is, would an extra step do anything the existing check does not or can not do? I'm not sure it would. Checking links in...
Thanks for that explanation! I wonder then if we could simplify and keep all link-checking (internal and external) inside the jupyterbook build command? Or do you think it's best to...
> It has been set up for not failing when it finds broken links, so that instead of fixing them all on one go ourselves we could open issues for...
Perhaps @JimMadge would like to join too? [details](https://github.com/alan-turing-institute/the-turing-way/blob/master/project_management/online-collaboration-cafe.md)
> there's a `--keep-going` flag that will run the whole process and find _all_ the warnings before aborting. **More things in the world need this.**
@nathanbegbie Please do! This wasn't something I intended on tackling today, so feel free to get started 👾
@malvikasharan what should we do about this PR? I don't think the original team will be coming back to work on it, so it might need some signal boosting to...