Steven Herbst

This still doesn't appear to be resolved in the following tests: 1. ``cpu_system_tests/pi`` 2. ``cpu_system_tests/pi_pm`` The glitch test also has an unusual way of setting the PI control code, but...

Looks like this is being fixed by PR #125 -- could you confirm @sjkim85?

@sjkim85 are you happy with the current values we have for these parameters? Or do we still need to update them?

Looks like this is partially fixed -- editing ``*.yml`` files in ``config`` folder does cause code to be selectively rebuilt. However editing ``dragonphy/adapt_fir.py`` or ``dragonphy/fpga_models/*.py`` doesn't have a similar effect....

It looks like this was addressed in ``cpu_system_tests/loopback_sram``, but there is still some leftover code from the old approach. I think we should revisit this to make sure we're checking...

Sorry, one other thing -- this is related to [this](https://www.reddit.com/r/fictrac/comments/am67ms/error_grabbing_frame_from_pgr_usb3_camera/) reddit post.

Sure, PRs welcome! I haven't worked on this for awhile, but am glad to hear that you found it useful. This might also be a good time to bump the...

Sorry for the delay - just sent you an invite to be a collaborator for this repository.

OK great - could you open a pull request for this branch?