Sergio Garcia

Results 12 comments of Sergio Garcia

> Hi everyone, > > I'm a developer at WalletConnect and I'd like to help you get this PR merged. We are working on adding support for Starknet so it'd...

> I would suggest adding two more rules to reduce potential ambiguity some more: > > * Name can't be enclosed in whitespace characters > * Name can't contain the...

> For the whitespace rule I would assume just using the word "whitespace" and relying on the `\s` RegEx could be sufficient. I would hope that it's mostly standardized between...

@ArielElp can we merge this?

> @sgc-code hey, do you need old state history? Like, being able to query old states with an old block_id? Hi, @FabijanC if we have a flag to disable old...

> #1039 - Don't change implementation, clarify the SNIP > #1342 - Don't change implementation, clarify the snip, have a new revision if the change is necessary > #1348 -...

I think it's missing the fixes for these two issues: https://github.com/starknet-io/starknet.js/issues/1287 and https://github.com/starknet-io/starknet.js/issues/1362

Hi, i understand that the SNIP12 wasn't always clear, and i think we should add clarifications for instance to explain that shortstrings use ASCII encoding. But IMO there's no need...

> For something to be recognized as an enum or merkletree entry it needs to have the type property No sure what you mean @penovicp , in this example both...

> Neither has `type: "enum"`. @penovicp correct, but any reason why that shouldn't work? the spec doesn't say anything about disallowing enums