sgartner03
sgartner03
Hi @timtebeek , the condition `onlyIfUsing == null && getResolutionResult().getParent() != null && acc.pomsDefinedInCurrentRepository.contains(getResolutionResult().getParent().getPom().getGav())` in AddDependency Line 215 prevents the dependency from being added in some cases. https://github.com/openrewrite/rewrite/blob/b64e1ed56584a03173c55abb831208af6e95afa3/rewrite-maven/src/main/java/org/openrewrite/maven/AddDependency.java#L238-L240 I tried...
Hi, I already understood your doubts about `specificModuleName`. However, I am not able to just pair this recipe with a precondition for selecting a single module or multiple modules. That's...
Hi @timtebeek, I've incorporated the suggested changes from the GH Action. I think this contribution matches your code styling now.
@ThomasKianek-Gepardec @Xaeras
Hi @timtebeek, yes exactly that is what this recipe does. Thank you for your, feedback, I'll incorporate it now.
Hi, I've added 3 more tests. This tests: - Multiple params - Empty Methods - Parameters of other type. As of now, this recipe only supports Strings and GStrings
@timtebeek
Hey @timtebeek ! Thank you for your extensive feedback. This is really valuable for me - so far I've only developed InHouse-Recipes for one Repo, where I didn't focus on...