Sam Fortiner comments

Results 7 comments of


                                            Sam Fortiner

Require feature developers to provide a reasoning when omitting a feature flag

I think there's a bit more improvement that could be done here. Finch is specific to the experimentation stage, but the feature flag name should be known and leveraged while...

[css-overscroll-scrollend-events] Content has no way of understanding whether it is being overscrolled or whether scroll has ended

Does scrollend fire after all overscroll events are done firing for a scroller? Or at the moment when events transition from scroll to overscroll? It's not clear to me right...

[css-overscroll-scrollend-events] Content has no way of understanding whether it is being overscrolled or whether scroll has ended

I'm wondering how the overscroll event works with inertial scroll, specifically the calculation of the deltaX/Y values. When the overscroll is caused by the user keeping their finger(s) down and...

[css-overscroll-scrollend-events] Content has no way of understanding whether it is being overscrolled or whether scroll has ended

Thoughts on my questions about deltaX/Y values when they are being updated via inertia or the tension/spring like effect to move an overscroll back to its normal scroll boundary?

[css-overscroll-scrollend-events] Content has no way of understanding whether it is being overscrolled or whether scroll has ended

If I'm understanding correctly, @smfr is saying to report the actual overscroll amount but @NavidZ is saying to report the amount we would have scrolled if we didn't hit a...

Trial owner email does not accept other than @google.com

Wondering if this is just a form validation failure. Validated here: https://github.com/GoogleChrome/chromium-dashboard/blob/cab207ef33d65dd995b07329f728acc1d92084fc/client-src/elements/form-field-specs.ts#L2048 Via a regex defined here: https://github.com/GoogleChrome/chromium-dashboard/blob/cab207ef33d65dd995b07329f728acc1d92084fc/client-src/elements/form-field-specs.ts#L123

I2P e-mail probably shouldn't include finch fields

This is also discussed in #3677. Makes sense to me that feature flag names (base:Feature strings used to enable/disable a feature via --enable-features) would be part of a I2P since...